Don't download releases-index.json to resolve major version (#560)

* Don't download releases-index.json to resolving major version

Starting with .NET 5 the minor version is always zero.
The earlier releases don't get new versions anymore so we can hardcode the minor version instead of downloading releases-index.json to do the lookup.

* Remove unused variable

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Commit dist/setup/index.js

* Refresh after copilot commits

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dist/setup/index.js

@@ -78768,7 +78768,22 @@ class DotnetVersionResolver {
             this.resolvedArgument.value = `${major}.${minor}`;
         }
         else if (this.isNumericTag(major)) {
-            this.resolvedArgument.value = await this.getLatestByMajorTag(major);
+            // Starting with .NET 5, the minor version is always zero.
+            // Hardcode the earlier versions because they will not get new releases.
+            switch (major) {
+                case '1':
+                    this.resolvedArgument.value = '1.1';
+                    break;
+                case '2':
+                    this.resolvedArgument.value = '2.2';
+                    break;
+                case '3':
+                    this.resolvedArgument.value = '3.1';
+                    break;
+                default:
+                    this.resolvedArgument.value = `${major}.0`;
+                    break;
+            }
         }
         else {
             // If "dotnet-version" is specified as *, x or X resolve latest version of .NET explicitly from LTS channel. The version argument will default to "latest" by install-dotnet script.
@@ -78832,23 +78847,6 @@ class DotnetVersionResolver {
         }
         return releasesInfo[0]['channel-version'];
     }
-    async getLatestByMajorTag(majorTag) {
-        const httpClient = new hc.HttpClient('actions/setup-dotnet', [], {
-            allowRetries: true,
-            maxRetries: 3
-        });
-        const response = await httpClient.getJson(DotnetVersionResolver.DotnetCoreIndexUrl);
-        const result = response.result || {};
-        const releasesInfo = result['releases-index'];
-        const releaseInfo = releasesInfo.find(info => {
-            const sdkParts = info['channel-version'].split('.');
-            return sdkParts[0] === majorTag;
-        });
-        if (!releaseInfo) {
-            throw new Error(`Could not find info for version with major tag: "${majorTag}" at ${DotnetVersionResolver.DotnetCoreIndexUrl}`);
-        }
-        return releaseInfo['channel-version'];
-    }
     static DotnetCoreIndexUrl = 'https://builds.dotnet.microsoft.com/dotnet/release-metadata/releases-index.json';
 }
 exports.DotnetVersionResolver = DotnetVersionResolver;

package-lock.json

@@ -3617,9 +3617,9 @@
       "dev": true
     },
     "node_modules/fast-xml-builder": {
-      "version": "1.2.0",
+      "version": "1.1.4",
-      "resolved": "https://registry.npmjs.org/fast-xml-builder/-/fast-xml-builder-1.2.0.tgz",
+      "resolved": "https://registry.npmjs.org/fast-xml-builder/-/fast-xml-builder-1.1.4.tgz",
-      "integrity": "sha512-00aAWieqff+ZJhsXA4g1g7M8k+7AYoMUUHF+/zFb5U6Uv/P0Vl4QZo84/IcufzYalLuEj9928bXN9PbbFzMF0Q==",
+      "integrity": "sha512-f2jhpN4Eccy0/Uz9csxh3Nu6q4ErKxf0XIsasomfOihuSUa3/xw6w8dnOtCDgEItQFJG8KyXPzQXzcODDrrbOg==",
       "funding": [
         {
           "type": "github",
@@ -3628,8 +3628,7 @@
       ],
       "license": "MIT",
       "dependencies": {
-        "path-expression-matcher": "^1.5.0",
+        "path-expression-matcher": "^1.1.3"
-        "xml-naming": "^0.1.0"
       }
     },
     "node_modules/fast-xml-parser": {
@@ -5150,9 +5149,9 @@
       }
     },
     "node_modules/path-expression-matcher": {
-      "version": "1.5.0",
+      "version": "1.4.0",
-      "resolved": "https://registry.npmjs.org/path-expression-matcher/-/path-expression-matcher-1.5.0.tgz",
+      "resolved": "https://registry.npmjs.org/path-expression-matcher/-/path-expression-matcher-1.4.0.tgz",
-      "integrity": "sha512-cbrerZV+6rvdQrrD+iGMcZFEiiSrbv9Tfdkvnusy6y0x0GKBXREFg/Y65GhIfm0tnLntThhzCnfKwp1WRjeCyQ==",
+      "integrity": "sha512-s4DQMxIdhj3jLFWd9LxHOplj4p9yQ4ffMGowFf3cpEgrrJjEhN0V5nxw4Ye1EViAGDoL4/1AeO6qHpqYPOzE4Q==",
       "funding": [
         {
           "type": "github",
@@ -6059,21 +6058,6 @@
         "node": "^12.13.0 || ^14.15.0 || >=16.0.0"
       }
     },
-    "node_modules/xml-naming": {
-      "version": "0.1.0",
-      "resolved": "https://registry.npmjs.org/xml-naming/-/xml-naming-0.1.0.tgz",
-      "integrity": "sha512-k8KO9hrMyNk6tUWqUfkTEZbezRRpONVOzUTnc97VnCvyj6Tf9lyUR9EDAIeiVLv56jsMcoXEwjW8Kv5yPY52lw==",
-      "funding": [
-        {
-          "type": "github",
-          "url": "https://github.com/sponsors/NaturalIntelligence"
-        }
-      ],
-      "license": "MIT",
-      "engines": {
-        "node": ">=16.0.0"
-      }
-    },
     "node_modules/y18n": {
       "version": "5.0.8",
       "resolved": "https://registry.npmjs.org/y18n/-/y18n-5.0.8.tgz",

src/installer.ts

@@ -125,7 +125,22 @@ export class DotnetVersionResolver {
     } else if (this.isNumericTag(major) && this.isNumericTag(minor)) {
       this.resolvedArgument.value = `${major}.${minor}`;
     } else if (this.isNumericTag(major)) {
-      this.resolvedArgument.value = await this.getLatestByMajorTag(major);
+      // Starting with .NET 5, the minor version is always zero.
+      // Hardcode the earlier versions because they will not get new releases.
+      switch (major) {
+        case '1':
+          this.resolvedArgument.value = '1.1';
+          break;
+        case '2':
+          this.resolvedArgument.value = '2.2';
+          break;
+        case '3':
+          this.resolvedArgument.value = '3.1';
+          break;
+        default:
+          this.resolvedArgument.value = `${major}.0`;
+          break;
+      }
     } else {
       // If "dotnet-version" is specified as *, x or X resolve latest version of .NET explicitly from LTS channel. The version argument will default to "latest" by install-dotnet script.
       this.resolvedArgument.value = 'LTS';
@@ -207,33 +222,6 @@ export class DotnetVersionResolver {
     return releasesInfo[0]['channel-version'];
   }
 
-  private async getLatestByMajorTag(majorTag: string): Promise<string> {
-    const httpClient = new hc.HttpClient('actions/setup-dotnet', [], {
-      allowRetries: true,
-      maxRetries: 3
-    });
-
-    const response = await httpClient.getJson<any>(
-      DotnetVersionResolver.DotnetCoreIndexUrl
-    );
-
-    const result = response.result || {};
-    const releasesInfo: any[] = result['releases-index'];
-
-    const releaseInfo = releasesInfo.find(info => {
-      const sdkParts: string[] = info['channel-version'].split('.');
-      return sdkParts[0] === majorTag;
-    });
-
-    if (!releaseInfo) {
-      throw new Error(
-        `Could not find info for version with major tag: "${majorTag}" at ${DotnetVersionResolver.DotnetCoreIndexUrl}`
-      );
-    }
-
-    return releaseInfo['channel-version'];
-  }
-
   static DotnetCoreIndexUrl =
     'https://builds.dotnet.microsoft.com/dotnet/release-metadata/releases-index.json';
 }