mirror of
https://github.com/actions/stale.git
synced 2026-07-02 06:08:32 +01:00
fix: only-issue-types does not affect PRs (#1338)
* fix: does not affect PRs * docs: mention new behaviour specifically in README.md * test: add new test case to avoid regression * chore: run build
This commit is contained in:
@@ -569,6 +569,8 @@ A comma separated list of allowed issue types. Only issues with a matching type
|
||||
|
||||
If unset (or an empty string), this option will not alter the stale workflow.
|
||||
|
||||
This option does not affect PRs.
|
||||
|
||||
Default value: unset
|
||||
|
||||
### Usage
|
||||
|
||||
@@ -122,4 +122,37 @@ describe('only-issue-types option', () => {
|
||||
'A feature'
|
||||
]);
|
||||
});
|
||||
|
||||
test('should ignore onlyIssueTypes filter when item is a pull request', async () => {
|
||||
const opts: IIssuesProcessorOptions = {
|
||||
...DefaultProcessorOptions,
|
||||
onlyIssueTypes: 'bug'
|
||||
};
|
||||
const TestIssueList: Issue[] = [
|
||||
generateIssue(
|
||||
opts,
|
||||
1,
|
||||
'A pull request',
|
||||
'2020-01-01T17:00:00Z',
|
||||
'2020-01-01T17:00:00Z',
|
||||
false,
|
||||
true, // isPullRequest = true
|
||||
[],
|
||||
false,
|
||||
false,
|
||||
undefined,
|
||||
[],
|
||||
undefined // pull requests do not have an issue_type
|
||||
)
|
||||
];
|
||||
const processor = new IssuesProcessorMock(
|
||||
opts,
|
||||
alwaysFalseStateMock,
|
||||
async p => (p === 1 ? TestIssueList : []),
|
||||
async () => [],
|
||||
async () => new Date().toDateString()
|
||||
);
|
||||
await processor.processIssues(1);
|
||||
expect(processor.staleIssues.map(i => i.title)).toEqual(['A pull request']);
|
||||
});
|
||||
});
|
||||
|
||||
2
dist/index.js
vendored
2
dist/index.js
vendored
@@ -513,7 +513,7 @@ class IssuesProcessor {
|
||||
IssuesProcessor._endIssueProcessing(issue);
|
||||
return; // If the issue has an 'include-only-assigned' option set, process only issues with nonempty assignees list
|
||||
}
|
||||
if (this.options.onlyIssueTypes) {
|
||||
if (this.options.onlyIssueTypes && !issue.isPullRequest) {
|
||||
const allowedTypes = this.options.onlyIssueTypes
|
||||
.split(',')
|
||||
.map(t => t.trim().toLowerCase())
|
||||
|
||||
@@ -252,7 +252,7 @@ export class IssuesProcessor {
|
||||
return; // If the issue has an 'include-only-assigned' option set, process only issues with nonempty assignees list
|
||||
}
|
||||
|
||||
if (this.options.onlyIssueTypes) {
|
||||
if (this.options.onlyIssueTypes && !issue.isPullRequest) {
|
||||
const allowedTypes = this.options.onlyIssueTypes
|
||||
.split(',')
|
||||
.map(t => t.trim().toLowerCase())
|
||||
|
||||
Reference in New Issue
Block a user