Allow ordering (#97)

* allow ordering of issue lookup

__tests__/main.test.ts

@@ -44,7 +44,8 @@ const DefaultProcessorOptions: IssueProcessorOptions = {
   onlyLabels: '',
   operationsPerRun: 100,
   debugOnly: true,
-  removeStaleWhenUpdated: false
+  removeStaleWhenUpdated: false,
+  ascending: false
 };
 
 test('empty issue list results in 1 operation', async () => {

action.yml

@@ -39,6 +39,9 @@ inputs:
   debug-only:
     description: 'Run the processor in debug mode without actually performing any operations on live issues.'
     default: false
+  ascending:
+    description: 'The order to get issues or pull requests. Defaults to false, which is descending'
+    default: false
 runs:
   using: 'node12'
   main: 'dist/index.js'

src/IssueProcessor.ts

@@ -47,6 +47,7 @@ export interface IssueProcessorOptions {
   operationsPerRun: number;
   removeStaleWhenUpdated: boolean;
   debugOnly: boolean;
+  ascending: boolean;
 }
 
 /***
@@ -203,7 +204,7 @@ export class IssueProcessor {
 
     const issueHasUpdate: boolean = IssueProcessor.updatedSince(
       issue.updated_at,
-      this.options.daysBeforeClose + (this.options.daysBeforeStale ?? 0)
+      this.options.daysBeforeClose
     );
     core.info(`Issue #${issue.number} has been updated: ${issueHasUpdate}`);
 
@@ -268,28 +269,39 @@ export class IssueProcessor {
     sinceDate: string
   ): Promise<Comment[]> {
     // find any comments since date on the given issue
-    const comments = await this.client.issues.listComments({
+    try {
-      owner: github.context.repo.owner,
+      const comments = await this.client.issues.listComments({
-      repo: github.context.repo.repo,
+        owner: github.context.repo.owner,
-      issue_number: issueNumber,
+        repo: github.context.repo.repo,
-      since: sinceDate
+        issue_number: issueNumber,
-    });
+        since: sinceDate
-
+      });
-    return comments.data;
+      return comments.data;
+    } catch (error) {
+      core.error(`List issue comments error: ${error.message}`);
+      return Promise.resolve([]);
+    }
   }
 
   // grab issues from github in baches of 100
   private async getIssues(page: number): Promise<Issue[]> {
-    const issueResult: OctoKitIssueList = await this.client.issues.listForRepo({
+    try {
-      owner: github.context.repo.owner,
+      const issueResult: OctoKitIssueList = await this.client.issues.listForRepo(
-      repo: github.context.repo.repo,
+        {
-      state: 'open',
+          owner: github.context.repo.owner,
-      labels: this.options.onlyLabels,
+          repo: github.context.repo.repo,
-      per_page: 100,
+          state: 'open',
-      page
+          labels: this.options.onlyLabels,
-    });
+          per_page: 100,
-
+          direction: this.options.ascending ? 'asc' : 'desc',
-    return issueResult.data;
+          page
+        }
+      );
+      return issueResult.data;
+    } catch (error) {
+      core.error(`Get issues for repo error: ${error.message}`);
+      return Promise.resolve([]);
+    }
   }
 
   // Mark an issue as stale with a comment and a label
@@ -304,37 +316,36 @@ export class IssueProcessor {
 
     this.operationsLeft -= 2;
 
-    // We are about to modify the issue by adding a comment and applying a label, so update the modification timestamp
+    // if the issue is being marked stale, the updated date should be changed to right now
-    // to `days-before-stale` days ago to simulate as if we marked this issue stale on the very first day it actually
+    // so that close calculations work correctly
-    // became stale. This has the effect of respecting `days-before-close` no matter what value it is set to. The user
-    // can request to close the issue immediately by using `days-before-close` === 0, or they can set it to any number
-    // of days to wait before actually closing the issue.
-    const daysBeforeStaleInMillis =
-      1000 * 60 * 60 * 24 * this.options.daysBeforeStale;
     const newUpdatedAtDate: Date = new Date();
-    newUpdatedAtDate.setTime(
-      newUpdatedAtDate.getTime() - daysBeforeStaleInMillis
-    );
-
     issue.updated_at = newUpdatedAtDate.toString();
 
     if (this.options.debugOnly) {
       return;
     }
 
-    await this.client.issues.createComment({
+    try {
-      owner: github.context.repo.owner,
+      await this.client.issues.createComment({
-      repo: github.context.repo.repo,
+        owner: github.context.repo.owner,
-      issue_number: issue.number,
+        repo: github.context.repo.repo,
-      body: staleMessage
+        issue_number: issue.number,
-    });
+        body: staleMessage
+      });
+    } catch (error) {
+      core.error(`Error creating a comment: ${error.message}`);
+    }
 
-    await this.client.issues.addLabels({
+    try {
-      owner: github.context.repo.owner,
+      await this.client.issues.addLabels({
-      repo: github.context.repo.repo,
+        owner: github.context.repo.owner,
-      issue_number: issue.number,
+        repo: github.context.repo.repo,
-      labels: [staleLabel]
+        issue_number: issue.number,
-    });
+        labels: [staleLabel]
+      });
+    } catch (error) {
+      core.error(`Error adding a label: ${error.message}`);
+    }
   }
 
   // Close an issue based on staleness
@@ -351,12 +362,16 @@ export class IssueProcessor {
       return;
     }
 
-    await this.client.issues.update({
+    try {
-      owner: github.context.repo.owner,
+      await this.client.issues.update({
-      repo: github.context.repo.repo,
+        owner: github.context.repo.owner,
-      issue_number: issue.number,
+        repo: github.context.repo.repo,
-      state: 'closed'
+        issue_number: issue.number,
-    });
+        state: 'closed'
+      });
+    } catch (error) {
+      core.error(`Error updating an issue: ${error.message}`);
+    }
   }
 
   // Remove a label from an issue
@@ -373,12 +388,16 @@ export class IssueProcessor {
       return;
     }
 
-    await this.client.issues.removeLabel({
+    try {
-      owner: github.context.repo.owner,
+      await this.client.issues.removeLabel({
-      repo: github.context.repo.repo,
+        owner: github.context.repo.owner,
-      issue_number: issue.number,
+        repo: github.context.repo.repo,
-      name: encodeURIComponent(label) // A label can have a "?" in the name
+        issue_number: issue.number,
-    });
+        name: encodeURIComponent(label) // A label can have a "?" in the name
+      });
+    } catch (error) {
+      core.error(`Error removing a label: ${error.message}`);
+    }
   }
 
   // returns the creation date of a given label on an issue (or nothing if no label existed)

src/main.ts

@@ -35,7 +35,8 @@ function getAndValidateArgs(): IssueProcessorOptions {
     removeStaleWhenUpdated: !(
       core.getInput('remove-stale-when-updated') === 'false'
     ),
-    debugOnly: core.getInput('debug-only') === 'true'
+    debugOnly: core.getInput('debug-only') === 'true',
+    ascending: core.getInput('ascending') === 'true'
   };
 
   for (const numberInput of [