Merge pull request #670 from actions/thboop/node16upgrade

Update default runtime to node16

.github/workflows/check-dist.yml

@@ -23,16 +23,18 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Set Node.js 12.x
+      - name: Set Node.js 16.x
         uses: actions/setup-node@v1
         with:
-          node-version: 12.x
+          node-version: 16.x
 
       - name: Install dependencies
         run: npm ci
 
       - name: Rebuild the dist/ directory
-        run: npm run build
+        run: |
+          npm run build
+          npm run pack
 
       - name: Compare the expected and actual dist/ directories
         run: |

__tests__/classes/issues-processor-mock.ts

@@ -9,7 +9,7 @@ export class IssuesProcessorMock extends IssuesProcessor {
     options: IIssuesProcessorOptions,
     getIssues?: (page: number) => Promise<Issue[]>,
     listIssueComments?: (
-      issueNumber: number,
+      issue: Issue,
       sinceDate: string
     ) => Promise<IComment[]>,
     getLabelCreationDate?: (

action.yml

@@ -198,5 +198,5 @@ outputs:
   staled-issues-prs:
     description: 'List of all staled issues and pull requests.'
 runs:
-  using: 'node12'
+  using: 'node16'
   main: 'dist/index.js'

dist/index.js

@@ -613,17 +613,17 @@ class IssuesProcessor {
         });
     }
     // Grab comments for an issue since a given date
-    listIssueComments(issueNumber, sinceDate) {
+    listIssueComments(issue, sinceDate) {
         var _a;
         return __awaiter(this, void 0, void 0, function* () {
             // Find any comments since date on the given issue
             try {
-                this.operations.consumeOperation();
+                this._consumeIssueOperation(issue);
                 (_a = this.statistics) === null || _a === void 0 ? void 0 : _a.incrementFetchedItemsCommentsCount();
                 const comments = yield this.client.issues.listComments({
                     owner: github_1.context.repo.owner,
                     repo: github_1.context.repo.repo,
-                    issue_number: issueNumber,
+                    issue_number: issue.number,
                     since: sinceDate
                 });
                 return comments.data;
@@ -763,7 +763,7 @@ class IssuesProcessor {
                 return true;
             }
             // find any comments since the date
-            const comments = yield this.listIssueComments(issue.number, sinceDate);
+            const comments = yield this.listIssueComments(issue, sinceDate);
             const filteredComments = comments.filter(comment => comment.user.type === 'User' &&
                 comment.body.toLowerCase() !== staleMessage.toLowerCase());
             issueLogger.info(`Comments that are not the stale comment or another bot: ${logger_service_1.LoggerService.cyan(filteredComments.length)}`);
@@ -1014,7 +1014,7 @@ class IssuesProcessor {
             issueLogger.info(`Adding all the labels specified via the ${this._logger.createOptionLink(option_1.Option.LabelsToAddWhenUnstale)} option.`);
             this.addedLabelIssues.push(issue);
             try {
-                this.operations.consumeOperation();
+                this._consumeIssueOperation(issue);
                 (_a = this.statistics) === null || _a === void 0 ? void 0 : _a.incrementAddedItemsLabel(issue);
                 if (!this.options.debugOnly) {
                     yield this.client.issues.addLabels({

package.json

@@ -54,15 +54,15 @@
     "ansi-styles": "5.2.0",
     "eslint": "^7.28.0",
     "eslint-plugin-github": "^4.1.2",
-    "eslint-plugin-jest": "^24.4.2",
+    "eslint-plugin-jest": "^25.3.2",
     "jest": "^27.2.5",
-    "jest-circus": "^27.2.0",
+    "jest-circus": "^27.4.6",
     "jest-silent-reporter": "^0.5.0",
     "js-yaml": "^4.1.0",
-    "prettier": "^2.4.1",
+    "prettier": "^2.5.1",
     "standard-version": "^9.3.1",
     "terminal-link": "^2.1.1",
-    "ts-jest": "^27.0.5",
+    "ts-jest": "^27.1.2",
     "typescript": "^4.3.2"
   }
 }

src/classes/issues-processor.ts

@@ -510,17 +510,17 @@ export class IssuesProcessor {
 
   // Grab comments for an issue since a given date
   async listIssueComments(
-    issueNumber: Readonly<number>,
+    issue: Readonly<Issue>,
     sinceDate: Readonly<string>
   ): Promise<IComment[]> {
     // Find any comments since date on the given issue
     try {
-      this.operations.consumeOperation();
+      this._consumeIssueOperation(issue);
       this.statistics?.incrementFetchedItemsCommentsCount();
       const comments = await this.client.issues.listComments({
         owner: context.repo.owner,
         repo: context.repo.repo,
-        issue_number: issueNumber,
+        issue_number: issue.number,
         since: sinceDate
       });
       return comments.data;
@@ -734,7 +734,7 @@ export class IssuesProcessor {
     }
 
     // find any comments since the date
-    const comments = await this.listIssueComments(issue.number, sinceDate);
+    const comments = await this.listIssueComments(issue, sinceDate);
 
     const filteredComments = comments.filter(
       comment =>
@@ -1065,7 +1065,7 @@ export class IssuesProcessor {
     this.addedLabelIssues.push(issue);
 
     try {
-      this.operations.consumeOperation();
+      this._consumeIssueOperation(issue);
       this.statistics?.incrementAddedItemsLabel(issue);
       if (!this.options.debugOnly) {
         await this.client.issues.addLabels({