Fix change detection using Github API (#51)

fix: retrieve all changes via api

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.5.3
+- [Fixed mapping of removed/deleted change status from github API](https://github.com/dorny/paths-filter/pull/51)
+- [Fixed retrieval of all changes via Github API when there are 100+ changes](https://github.com/dorny/paths-filter/pull/50)
+
 ## v2.5.2
 - [Add support for multiple patterns when using file status](https://github.com/dorny/paths-filter/pull/48)
 - [Use picomatch directly instead of micromatch wrapper](https://github.com/dorny/paths-filter/pull/49)

README.md

@@ -62,6 +62,7 @@ For more scenarios see [examples](#examples) section.
 
 
 # What's New
+- Fixed retrieval of all changes via Github API when there are 100+ changes
 - Paths expressions are now evaluated using [picomatch](https://github.com/micromatch/picomatch) library
 - Support workflows triggered by any event
 - Fixed compatibility with older (<2.23) versions of git

dist/index.js

@@ -4729,11 +4729,13 @@ async function getChangedFilesFromGit(base, initialFetchDepth) {
 }
 // Uses github REST api to get list of files changed in PR
 async function getChangedFilesFromApi(token, pullRequest) {
-    core.info(`Fetching list of changed files for PR#${pullRequest.number} from Github API`);
+    core.startGroup(`Fetching list of changed files for PR#${pullRequest.number} from Github API`);
+    core.info(`Number of changed_files is ${pullRequest.changed_files}`);
     const client = new github.GitHub(token);
     const pageSize = 100;
     const files = [];
-    for (let page = 0; page * pageSize < pullRequest.changed_files; page++) {
+    for (let page = 1; (page - 1) * pageSize < pullRequest.changed_files; page++) {
+        core.info(`Invoking listFiles(pull_number: ${pullRequest.number}, page: ${page}, per_page: ${pageSize})`);
         const response = await client.pulls.listFiles({
             owner: github.context.repo.owner,
             repo: github.context.repo.repo,
@@ -4742,6 +4744,7 @@ async function getChangedFilesFromApi(token, pullRequest) {
             per_page: pageSize
         });
         for (const row of response.data) {
+            core.info(`[${row.status}] ${row.filename}`);
             // There's no obvious use-case for detection of renames
             // Therefore we treat it as if rename detection in git diff was turned off.
             // Rename is replaced by delete of original filename and add of new filename
@@ -4757,13 +4760,16 @@ async function getChangedFilesFromApi(token, pullRequest) {
                 });
             }
             else {
+                // Github status and git status variants are same except for deleted files
+                const status = row.status === 'removed' ? file_1.ChangeStatus.Deleted : row.status;
                 files.push({
                     filename: row.filename,
-                    status: row.status
+                    status
                 });
             }
         }
     }
+    core.endGroup();
     return files;
 }
 function exportResults(results, format) {

src/main.ts

@@ -123,11 +123,13 @@ async function getChangedFilesFromApi(
   token: string,
   pullRequest: Webhooks.WebhookPayloadPullRequestPullRequest
 ): Promise<File[]> {
-  core.info(`Fetching list of changed files for PR#${pullRequest.number} from Github API`)
+  core.startGroup(`Fetching list of changed files for PR#${pullRequest.number} from Github API`)
+  core.info(`Number of changed_files is ${pullRequest.changed_files}`)
   const client = new github.GitHub(token)
   const pageSize = 100
   const files: File[] = []
-  for (let page = 0; page * pageSize < pullRequest.changed_files; page++) {
+  for (let page = 1; (page - 1) * pageSize < pullRequest.changed_files; page++) {
+    core.info(`Invoking listFiles(pull_number: ${pullRequest.number}, page: ${page}, per_page: ${pageSize})`)
     const response = await client.pulls.listFiles({
       owner: github.context.repo.owner,
       repo: github.context.repo.repo,
@@ -136,6 +138,7 @@ async function getChangedFilesFromApi(
       per_page: pageSize
     })
     for (const row of response.data) {
+      core.info(`[${row.status}] ${row.filename}`)
       // There's no obvious use-case for detection of renames
       // Therefore we treat it as if rename detection in git diff was turned off.
       // Rename is replaced by delete of original filename and add of new filename
@@ -150,14 +153,17 @@ async function getChangedFilesFromApi(
           status: ChangeStatus.Deleted
         })
       } else {
+        // Github status and git status variants are same except for deleted files
+        const status = row.status === 'removed' ? ChangeStatus.Deleted : (row.status as ChangeStatus)
         files.push({
           filename: row.filename,
-          status: row.status as ChangeStatus
+          status
         })
       }
     }
   }
 
+  core.endGroup()
   return files
 }