Clean up

Example runs once per day instead of per hour

README.md

@@ -11,7 +11,7 @@ Basic:
 name: "Close stale issues"
 on:
   schedule:
-  - cron: "0 * * * *"
+  - cron: "0 0 * * *"
 
 jobs:
   stale:
@@ -29,7 +29,7 @@ Configure stale timeouts:
 name: "Close stale issues"
 on:
   schedule:
-  - cron: "0 * * * *"
+  - cron: "0 0 * * *"
 
 jobs:
   stale:
@@ -48,7 +48,7 @@ Configure labels:
 name: "Close stale issues"
 on:
   schedule:
-  - cron: "0 * * * *"
+  - cron: "0 0 * * *"
 
 jobs:
   stale:
@@ -60,5 +60,7 @@ jobs:
         stale-issue-message: 'Stale issue message'
         stale-pr-message: 'Stale issue message'
         stale-issue-label: 'no-issue-activity'
+        exempt-issue-label: 'awaiting-approval'
         stale-pr-label: 'no-pr-activity'
+        exempt-pr-label: 'awaiting-approval'
 ```

action.yml

@@ -6,24 +6,28 @@ inputs:
     description: 'Token for the repo. Can be passed in using {{ secrets.GITHUB_TOKEN }}'
     required: true
   stale-issue-message:
-    description: 'The message to post on the issue when tagging it. If none provided, will not mark iusses stale.'
+    description: 'The message to post on the issue when tagging it. If none provided, will not mark issues stale.'
   stale-pr-message:
-    description: 'The message to post on the pr when tagging it. If none provided, will not mark prs stale.'
+    description: 'The message to post on the pr when tagging it. If none provided, will not mark pull requests stale.'
   days-before-stale:
     description: 'The number of days old an issue can be before marking it stale'
     default: 60
   days-before-close:
-    description: 'The number of days to wait to close an issue or pr after it being marked stale'
+    description: 'The number of days to wait to close an issue or pull request after it being marked stale. Set to -1 to never close stale issues.'
     default: 7
   stale-issue-label:
     description: 'The label to apply when an issue is stale'
     default: 'Stale'
+  exempt-issue-label:
+    description: 'The label to apply when an issue is exempt from being marked stale'
   stale-pr-label:
-    description: 'The label to apply when a pr is stale'
+    description: 'The label to apply when a pull request is stale'
     default: 'Stale'
+  exempt-pr-label:
+    description: 'The label to apply when a pull request is exempt from being marked stale'
   operations-per-run:
     description: 'The maximum number of operations per run, used to control rate limiting'
     default: 30
 runs:
   using: 'node12'
-  main: 'lib/main.js'
+  main: 'lib/main.js'

src/main.ts

@@ -12,7 +12,9 @@ type Args = {
   daysBeforeStale: number;
   daysBeforeClose: number;
   staleIssueLabel: string;
+  exemptIssueLabel: string;
   stalePrLabel: string;
+  exemptPrLabel: string;
   operationsPerRun: number;
 };
 
@@ -59,9 +61,12 @@ async function processIssues(
     }
 
     let staleLabel = isPr ? args.stalePrLabel : args.staleIssueLabel;
+    let exemptLabel = isPr ? args.exemptPrLabel : args.exemptIssueLabel;
 
-    if (isLabeledStale(issue, staleLabel)) {
-      if (wasLastUpdatedBefore(issue, args.daysBeforeClose)) {
+    if (exemptLabel && isLabeled(issue, exemptLabel)) {
+      continue;
+    } else if (isLabeled(issue, staleLabel)) {
+      if (args.daysBeforeClose >= 0 && wasLastUpdatedBefore(issue, args.daysBeforeClose)) {
         operationsLeft -= await closeIssue(client, issue);
       } else {
         continue;
@@ -85,14 +90,14 @@ async function processIssues(
   return await processIssues(client, args, operationsLeft, page + 1);
 }
 
-function isLabeledStale(issue: Issue, label: string): boolean {
+function isLabeled(issue: Issue, label: string): boolean {
   const labelComparer: (l: IssueLabel) => boolean = l =>
     label.localeCompare(l.name, undefined, {sensitivity: 'accent'}) === 0;
   return issue.labels.filter(labelComparer).length > 0;
 }
 
 function wasLastUpdatedBefore(issue: Issue, num_days: number): boolean {
-  const daysInMillis = 1000 * 60 * 60 * num_days;
+  const daysInMillis = 1000 * 60 * 60 * 24 * num_days;
   const millisSinceLastUpdated =
     new Date().getTime() - new Date(issue.updated_at).getTime();
   return millisSinceLastUpdated >= daysInMillis;
@@ -151,7 +156,9 @@ function getAndValidateArgs(): Args {
       core.getInput('days-before-close', {required: true})
     ),
     staleIssueLabel: core.getInput('stale-issue-label', {required: true}),
+    exemptIssueLabel: core.getInput('exempt-issue-label'),
     stalePrLabel: core.getInput('stale-pr-label', {required: true}),
+    exemptPrLabel: core.getInput('exempt-pr-label'),
     operationsPerRun: parseInt(
       core.getInput('operations-per-run', {required: true})
     )