Update to latest actions and octokit libraries (#124)

Upgrade to latest libraries but use "any" for the client until I figure out how to use the right type

.eslintrc.json

@@ -1,6 +1,6 @@
 {
     "plugins": ["jest", "@typescript-eslint"],
-    "extends": ["plugin:github/es6"],
+    "extends": ["plugin:github/recommended"],
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
       "ecmaVersion": 9,
@@ -16,11 +16,10 @@
       "@typescript-eslint/no-require-imports": "error",
       "@typescript-eslint/array-type": "error",
       "@typescript-eslint/await-thenable": "error",
-      "@typescript-eslint/ban-ts-ignore": "error",
+      "@typescript-eslint/ban-ts-comment": "error",
       "camelcase": "off",
-      "@typescript-eslint/class-name-casing": "error",
+      "@typescript-eslint/consistent-type-assertions": "error",
       "@typescript-eslint/func-call-spacing": ["error", "never"],
-      "@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
       "@typescript-eslint/no-array-constructor": "error",
       "@typescript-eslint/no-empty-interface": "error",
       "@typescript-eslint/no-explicit-any": "off",
@@ -30,7 +29,6 @@
       "@typescript-eslint/no-misused-new": "error",
       "@typescript-eslint/no-namespace": "error",
       "@typescript-eslint/no-non-null-assertion": "warn",
-      "@typescript-eslint/no-object-literal-type-assertion": "error",
       "@typescript-eslint/no-unnecessary-qualifier": "error",
       "@typescript-eslint/no-unnecessary-type-assertion": "error",
       "@typescript-eslint/no-useless-constructor": "error",
@@ -38,7 +36,6 @@
       "@typescript-eslint/prefer-for-of": "warn",
       "@typescript-eslint/prefer-function-type": "warn",
       "@typescript-eslint/prefer-includes": "error",
-      "@typescript-eslint/prefer-interface": "error",
       "@typescript-eslint/prefer-string-starts-ends-with": "error",
       "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/require-array-sort-compare": "error",

package.json

@@ -26,8 +26,8 @@
   "license": "MIT",
   "dependencies": {
     "@actions/core": "^1.2.4",
-    "@actions/github": "^2.2.0",
-    "@octokit/rest": "^16.43.1",
+    "@actions/github": "^4.0.0",
+    "@octokit/rest": "^18.0.2",
     "semver": "^7.3.2"
   },
   "devDependencies": {
@@ -37,7 +37,7 @@
     "@typescript-eslint/parser": "^3.7.0",
     "@zeit/ncc": "^0.20.5",
     "eslint": "^5.16.0",
-    "eslint-plugin-github": "^2.0.0",
+    "eslint-plugin-github": "^4.0.1",
     "eslint-plugin-jest": "^23.18.0",
     "jest": "^24.9.0",
     "jest-circus": "^26.1.0",

src/IssueProcessor.ts

@@ -1,8 +1,6 @@
 import * as core from '@actions/core';
-import * as github from '@actions/github';
-import {Octokit} from '@octokit/rest';
-
-type OctoKitIssueList = Octokit.Response<Octokit.IssuesListForRepoResponse>;
+import {context, getOctokit} from '@actions/github';
+import {GetResponseTypeFromEndpointMethod} from '@octokit/types';
 
 export interface Issue {
   title: string;
@@ -58,9 +56,9 @@ export interface IssueProcessorOptions {
  * Handle processing of issues for staleness/closure.
  */
 export class IssueProcessor {
-  readonly client: github.GitHub;
+  readonly client: any; // need to make this the correct type
   readonly options: IssueProcessorOptions;
-  private operationsLeft: number = 0;
+  private operationsLeft = 0;
 
   readonly staleIssues: Issue[] = [];
   readonly closedIssues: Issue[] = [];
@@ -80,7 +78,7 @@ export class IssueProcessor {
   ) {
     this.options = options;
     this.operationsLeft = options.operationsPerRun;
-    this.client = new github.GitHub(options.repoToken);
+    this.client = getOctokit(options.repoToken);
 
     if (getIssues) {
       this.getIssues = getIssues;
@@ -101,7 +99,7 @@ export class IssueProcessor {
     }
   }
 
-  async processIssues(page: number = 1): Promise<number> {
+  async processIssues(page = 1): Promise<number> {
     // get the next batch of issues
     const issues: Issue[] = await this.getIssues(page);
     this.operationsLeft -= 1;
@@ -268,12 +266,11 @@ export class IssueProcessor {
 
     const filteredComments = comments.filter(
       comment =>
-        comment.user.type === 'User' &&
-        comment.user.login !== github.context.actor
+        comment.user.type === 'User' && comment.user.login !== context.actor
     );
 
     core.info(
-      `Comments not made by ${github.context.actor} or another bot: ${filteredComments.length}`
+      `Comments not made by ${context.actor} or another bot: ${filteredComments.length}`
     );
 
     // if there are any user comments returned
@@ -288,8 +285,8 @@ export class IssueProcessor {
     // find any comments since date on the given issue
     try {
       const comments = await this.client.issues.listComments({
-        owner: github.context.repo.owner,
-        repo: github.context.repo.repo,
+        owner: context.repo.owner,
+        repo: context.repo.repo,
         issue_number: issueNumber,
         since: sinceDate
       });
@@ -302,11 +299,15 @@ export class IssueProcessor {
 
   // grab issues from github in baches of 100
   private async getIssues(page: number): Promise<Issue[]> {
+    // generate type for response
+    const endpoint = this.client.issues.listForRepo;
+    type OctoKitIssueList = GetResponseTypeFromEndpointMethod<typeof endpoint>;
+
     try {
       const issueResult: OctoKitIssueList = await this.client.issues.listForRepo(
         {
-          owner: github.context.repo.owner,
-          repo: github.context.repo.repo,
+          owner: context.repo.owner,
+          repo: context.repo.repo,
           state: 'open',
           labels: this.options.onlyLabels,
           per_page: 100,
@@ -346,8 +347,8 @@ export class IssueProcessor {
     if (!skipMessage) {
       try {
         await this.client.issues.createComment({
-          owner: github.context.repo.owner,
-          repo: github.context.repo.repo,
+          owner: context.repo.owner,
+          repo: context.repo.repo,
           issue_number: issue.number,
           body: staleMessage
         });
@@ -358,8 +359,8 @@ export class IssueProcessor {
 
     try {
       await this.client.issues.addLabels({
-        owner: github.context.repo.owner,
-        repo: github.context.repo.repo,
+        owner: context.repo.owner,
+        repo: context.repo.repo,
         issue_number: issue.number,
         labels: [staleLabel]
       });
@@ -385,8 +386,8 @@ export class IssueProcessor {
     if (closeMessage) {
       try {
         await this.client.issues.createComment({
-          owner: github.context.repo.owner,
-          repo: github.context.repo.repo,
+          owner: context.repo.owner,
+          repo: context.repo.repo,
           issue_number: issue.number,
           body: closeMessage
         });
@@ -397,8 +398,8 @@ export class IssueProcessor {
 
     try {
       await this.client.issues.update({
-        owner: github.context.repo.owner,
-        repo: github.context.repo.repo,
+        owner: context.repo.owner,
+        repo: context.repo.repo,
         issue_number: issue.number,
         state: 'closed'
       });
@@ -423,8 +424,8 @@ export class IssueProcessor {
 
     try {
       await this.client.issues.removeLabel({
-        owner: github.context.repo.owner,
-        repo: github.context.repo.repo,
+        owner: context.repo.owner,
+        repo: context.repo.repo,
         issue_number: issue.number,
         name: encodeURIComponent(label) // A label can have a "?" in the name
       });
@@ -444,8 +445,8 @@ export class IssueProcessor {
     this.operationsLeft -= 1;
 
     const options = this.client.issues.listEvents.endpoint.merge({
-      owner: github.context.repo.owner,
-      repo: github.context.repo.repo,
+      owner: context.repo.owner,
+      repo: context.repo.repo,
       per_page: 100,
       issue_number: issue.number
     });